Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] Placate clang warning string-plus-int #947

Merged
merged 1 commit into from
May 26, 2021
Merged

[Trivial] Placate clang warning string-plus-int #947

merged 1 commit into from
May 26, 2021

Conversation

Zannick
Copy link
Collaborator

@Zannick Zannick commented May 18, 2021

Replace eg "tv"+2 with the suggested syntax of &"tv"[2].

Testing Results

Built veild and run with gcc, clang.

@Zannick
[Trivial] Placate clang warning string-plus-int
219a159 
Replace eg `"tv"+2` with the suggested syntax of `&"tv"[2]`.
@Zannick Zannick self-assigned this May 18, 2021
@WetOne
Copy link
Collaborator

WetOne commented May 19, 2021

utACK 219a159

CaveSpectre11
CaveSpectre11 approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 219a159

codeofalltrades
codeofalltrades approved these changes May 23, 2021
View reviewed changes
Copy link
Collaborator

@codeofalltrades codeofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 219a159

@codeofalltrades codeofalltrades added the Tag: Waiting For QA A pull review is waiting for QA to test the pull request label May 23, 2021
@codeofalltrades codeofalltrades merged commit 9840f3c into Veil-Project:master May 26, 2021
@Zannick Zannick deleted the clang1 branch October 22, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WetOne WetOne WetOne approved these changes

@codeofalltrades codeofalltrades codeofalltrades approved these changes

@CaveSpectre11 CaveSpectre11 CaveSpectre11 approved these changes

Assignees

@Zannick Zannick

Labels
Tag: Build System Tag: Waiting For QA A pull review is waiting for QA to test the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zannick @WetOne @CaveSpectre11 @codeofalltrades